Generate test protobuf using the buf tool
#354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hashicorp/team-ip-compliance, waiting on review please |
sonamtenzin2
approved these changes
Aug 7, 2025
jbardin
force-pushed
the
jbardin/panic-logging-cleanup
branch
from
2b902c6 to
6a167cc
Compare
It wasn't clear which versions of the protobuf tooling needed to be used to generate the test code, and updating them required some additional changes. Since the `buf` tool was adopted to generate the example code, use the same tool to make generating the test code easier too.
jbardin
force-pushed
the
jbardin/generate-test-protobuf
branch
from
ea6ae66 to
33ebac7
Compare
sonamtenzin2
approved these changes
Aug 7, 2025
jbardin
added a commit
that referenced
this pull request
Aug 8, 2025
…353) * cleanup panic logging flag Don't shadow the builtin `panic` symbol. Remove the redundant `false` assignments. Flatten the if block since we are already using a switch. * add Panic to grpc test service * update impls with new Panic method * test that server panics go to ERROR * CHANGELOG * fix test plugin mapping * use Debug for logger test to avoid timed output * Use buf to generate test proto (#354) It wasn't clear which versions of the protobuf tooling needed to be used to generate the test code, and updating them required some additional changes. Since the `buf` tool was adopted to generate the example code, use the same tool to make generating the test code easier too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't clear which versions of the protobuf tooling needed to be used to generate the test code, and updating them required some additional changes. Since the
buftool was adopted to generate the example code, use the same tool to make generating the test code easier too.