This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Remove HHClientLinter from NON_DEFAULT_LINTERS #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atry
approved these changes
Nov 26, 2021
Atry
added a commit
that referenced
this pull request
Nov 30, 2021
Even though we don't want to include `HHClientLinter` in the `NON_DEFAULT_LINTERS` for now, it is still beneficial to dogfood the linter in the `hhast` repository. This PR is based on #411 and additionally add `Facebook\HHAST\HHClientLinter` to `extraLinters`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having it here enables it with the
alloption, but #408 and #409 are release blockersIt should be possible to enable this just for HHAST via
extraLintersin the config, in a followup, but on vacation atm so doing the minimum here to getmainback to a releasable state