This is probably a worthwhile change on itself, but I don't think it should be needed here: does /*HHAST_IGNORE_ALL[1234]*/ not work for these? If not, that should be fixed:

• for consistency
• per-file suppressions via config is not scalable, especially as json's lack of support for trailing commas increases the risk of merge conflicts

This is probably a worthwhile change on itself, but I don't think it should be needed here: does /*HHAST_IGNORE_ALL[1234]*/ not work for these? If not, that should be fixed:

I believe this PR intends to address my comment on #409

This might also be a nice alternative to .LICENSE_HEADER.hh.txt. The LicenseHeaderLinter predates linter configuration and uses a well-known naming convention for setting per directory license headers instead. Once configuration is able to be declared in a override, this system can be supplemented using a configuration.

This is probably a worthwhile change on itself, but I don't think it should be needed here: does /*HHAST_IGNORE_ALL[1234]*/ not work for these? If not, that should be fixed:

• for consistency
• per-file suppressions via config is not scalable, especially as json's lack of support for trailing commas increases the risk of merge conflicts

I suppose people could use this PR to suppress linter errors in dependencies, where you cannot easily add HHAST_IGNORE_ALL comments.

I suppose people could use this PR to suppress linter errors in dependencies, where you cannot easily add HHAST_IGNORE_ALL comments.

People should not be linting their dependencies; lint-cleanness should be considered an implementation detail

This is probably a worthwhile change on itself,

Just to clarify what I meant here:

I think this PR is good, and should probably be merged

I don't think the rest of the stack should depend on it :)

Rebased this PR to avoid dependencies between other PRs

XHP change seems needed because of this, but should be a separate PR (and separate commit in the main branch) as it's independent and should be reviewed (and potentially bisected or reverted) separately