KEMBAR78
[CI] allow faster downloads from the Hub in CI. by sayakpaul · Pull Request #9478 · huggingface/diffusers · GitHub
Skip to content

Conversation

@sayakpaul
Copy link
Member

What does this PR do?

We can dramatically speed up downloads and uploads to the Hub with hf_transfer on high-bandwidth machines.

More about hf_transfer: https://huggingface.co/docs/huggingface_hub/v0.25.0/package_reference/environment_variables#hfhubenablehftransfer.

@sayakpaul sayakpaul requested a review from yiyixuxu September 20, 2024 02:31
@yiyixuxu yiyixuxu requested a review from ydshieh September 20, 2024 19:48
@yiyixuxu
Copy link
Collaborator

@ydshieh can you review this PR?

@sayakpaul sayakpaul requested a review from ydshieh September 23, 2024 14:52
Copy link
Contributor

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove

ENV HF_HUB_ENABLE_HF_TRANSFER=1

in docker files - leaving that for your call, otherwise all good on my side.

@yiyixuxu
Copy link
Collaborator

feel free to merge whenever it is ready!

@sayakpaul
Copy link
Member Author

sayakpaul commented Sep 24, 2024

Failing because the lastest Docker images don't have hf_transfer. Have triggered a fresh run here which should solve the problem.

@sayakpaul sayakpaul merged commit 28f9d84 into main Sep 24, 2024
12 checks passed
@sayakpaul sayakpaul deleted the hf_transformer_docker branch September 24, 2024 04:12
leisuzz pushed a commit to leisuzz/diffusers that referenced this pull request Oct 11, 2024
* allow faster downloads from the Hub in CI.

* HF_HUB_ENABLE_HF_TRANSFER: 1

* empty

* empty

* remove ENV HF_HUB_ENABLE_HF_TRANSFER=1.

* empty
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* allow faster downloads from the Hub in CI.

* HF_HUB_ENABLE_HF_TRANSFER: 1

* empty

* empty

* remove ENV HF_HUB_ENABLE_HF_TRANSFER=1.

* empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants