KEMBAR78
fix cogvideox autoencoder decode by Xiang-cd · Pull Request #9569 · huggingface/diffusers · GitHub
Skip to content

fix cogvideox autoencoder decode #9569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix cogvideox autoencoder decode #9569

merged 2 commits into from
Oct 2, 2024

Conversation

Xiang-cd
Copy link
Contributor

@Xiang-cd Xiang-cd commented Oct 2, 2024

What does this PR do?

fix bug of #9568

Fixes # (issue)
it is a simple fix with a line code change.
cogvideox train with mixsure of image and video, so the vae must support reconstruction of image, I fix the image case.

Before submitting

Who can review?

any one who familiar with vae.
@sayakpaul @DN6 @yiyixuxu

Core library:

Integrations:

HF projects:

-->

@Xiang-cd Xiang-cd mentioned this pull request Oct 2, 2024
Closed
a-r-r-o-w
a-r-r-o-w approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this looks correct!

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu October 2, 2024 07:58
@a-r-r-o-w
Copy link
Contributor

The commit was to resolve the merge conflict with the following conv_cache line

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
Copy link
Member

@a-r-r-o-w could we have caught it with some tests? Or not really? In the former case, let's also add a test?

@a-r-r-o-w
Copy link
Contributor

could we have caught it with some tests? Or not really? In the former case, let's also add a test?

Previously, we did not need to decode 1-frame video so this was not required, so testing for this case was not necessary. For Image-to-Video training, however, we need to be able to encode single frames (which is already supported). I think having decode work for a single frame is good to have too, since it could help with debugging.

@sayakpaul
Copy link
Member

Cool. If you want to feel free to support a test.

@Xiang-cd
Copy link
Contributor Author

Xiang-cd commented Oct 2, 2024

thank you, the support of image decode is useful for image-video mix tasks and further research, and this was my first pr to huggingface, hope it could merge. :)

@yiyixuxu yiyixuxu merged commit 7f323f0 into huggingface:main Oct 2, 2024
15 checks passed
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Oct 2, 2024

thanks for your PR!! @Xiang-cd

leisuzz pushed a commit to leisuzz/diffusers that referenced this pull request Oct 11, 2024
@Xiang-cd @a-r-r-o-w
fix cogvideox autoencoder decode (huggingface#9569)
51adece 
Co-authored-by: Aryan <aryan@huggingface.co>
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
@Xiang-cd @a-r-r-o-w @sayakpaul
fix cogvideox autoencoder decode (#9569)
bdeff1e 
Co-authored-by: Aryan <aryan@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxu yiyixuxu Awaiting requested review from yiyixuxu

1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Xiang-cd @a-r-r-o-w @HuggingFaceDocBuilderDev @sayakpaul @yiyixuxu