fix vae dtype when accelerate config using --mixed_precision="fp16" #9601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Oct 7, 2024
|
|
||
| # Move vae, transformer and text_encoder to device and cast to weight_dtype | ||
| vae.to(accelerator.device, dtype=torch.float32) | ||
| vae.to(accelerator.device, dtype=weight_dtype) |
There was a problem hiding this comment.
I think it should be like:
if args.upcast_vae:
vae.to(accelerator.device, dtype=torch.float32)
else:
vae.to(accelerator.device, dtype=weight_dtype)With upcast_vae being added to the arguments?
|
Thanks for the comment, I have modified the code. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
leisuzz
pushed a commit
to leisuzz/diffusers
that referenced
this pull request
Oct 11, 2024
…uggingface#9601) * fix vae dtype when accelerate config using --mixed_precision="fp16" * Add param for upcast vae
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
…9601) * fix vae dtype when accelerate config using --mixed_precision="fp16" * Add param for upcast vae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue #9560
Fix vae dtype when accelerate config using --mixed_precision="fp16".
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul