KEMBAR78
Fixed Nits in Docs and Example Script by ParagEkbote · Pull Request #9940 · huggingface/diffusers · GitHub
Skip to content

Fixed Nits in Docs and Example Script #9940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fixed Nits in Docs and Example Script #9940

merged 2 commits into from
Nov 18, 2024

Conversation

@ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Nov 16, 2024 •
edited
Loading

What does this PR do?

Closes the PR #9087 and Issue #9027. I've only updated the docstrings to not break anything. Please let me know if any improvements are needed and I will make the necessary changes.

Before submitting

Who can review?

cc: @yiyixuxu

a-r-r-o-w
a-r-r-o-w approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks like the correct thing to do since we can't change argument names without breaking backwards compatibility!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul requested a review from stevhliu November 17, 2024 02:21
stevhliu
stevhliu approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@stevhliu stevhliu merged commit 365a938 into huggingface:main Nov 18, 2024
15 checks passed
@ParagEkbote
Copy link
Contributor Author

ParagEkbote commented Nov 18, 2024 •
edited
Loading

Could you please see that #9087 and the issue #9027 gets closed to declutter?

cc: @a-r-r-o-w

@ParagEkbote ParagEkbote deleted the nit-in-docs branch November 18, 2024 17:08
This was referenced Nov 18, 2024
Closed
Closed
@a-r-r-o-w
Copy link
Contributor

Thanks for the fix and notifying! Marked those as closed

sayakpaul added a commit that referenced this pull request Dec 23, 2024
@ParagEkbote @sayakpaul
Fixed Nits in Docs and Example Script (#9940)
7b28265 
Fixed nits in docs and example script.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu stevhliu approved these changes

+1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ParagEkbote @HuggingFaceDocBuilderDev @a-r-r-o-w @stevhliu @sayakpaul