KEMBAR78
[TENTATIVE] Updating variable names HUGGINGFACE_CO_RESOLVE_ENDPOINT into HF_ENDPOINT. by Narsil · Pull Request #16445 · huggingface/transformers · GitHub
Skip to content

[TENTATIVE] Updating variable names HUGGINGFACE_CO_RESOLVE_ENDPOINT into HF_ENDPOINT. #16445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

[TENTATIVE] Updating variable names HUGGINGFACE_CO_RESOLVE_ENDPOINT into HF_ENDPOINT. #16445

merged 1 commit into from
Apr 29, 2022

Conversation

@Narsil
Copy link
Contributor

@Narsil Narsil commented Mar 28, 2022

What does this PR do?

HUGGINGFACE_CO_RESOLVE_ENDPOINT is deprecated and will go away in favor
of HF_ENDPOINT.

In order to maximize consistency, this PR renames the variable name itself.

This is tentative, since there might have been reasons to keep the old name for
the variable.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@LysandreJik @sgugger

@Narsil Narsil mentioned this pull request Mar 28, 2022
Merged
5 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 28, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger reviewed Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is purely cosmetic and internal, so I don't really see the point. We usually don't bother with renaming in those situations.

@Narsil
Copy link
Contributor Author

Narsil commented Mar 28, 2022

This is purely cosmetic and internal, so I don't really see the point. We usually don't bother with renaming in those situations.

Is there any downsides to making the modifications ?

Consistency in naming has a lot of merits, especially within HF ecosystem where the name is used in many different places and different repos. Here for instance, it took me several tries to find all variables that needed to be overridden in datasets, transformers and huggingface_hub. Changing the name increases the chances that new code respects that convention.

@LysandreJik
Copy link
Member

I think the renaming here makes sense as that's the variable name in other repositories; since there are no downsides, ok for me!

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

LysandreJik
LysandreJik approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change for me for consistency!

@Narsil
Copy link
Contributor Author

Narsil commented Apr 29, 2022

Ok, merging, feel free to revert if anything breaks !

@Narsil Narsil merged commit 4f3a14e into huggingface:main Apr 29, 2022
@Narsil Narsil deleted the changing_variable_names branch April 29, 2022 15:44
Narsil added a commit to Narsil/transformers that referenced this pull request Apr 29, 2022
@Narsil
Revert "Updating variable names. (huggingface#16445)"
bd36779 
This reverts commit 4f3a14e.
sgugger pushed a commit that referenced this pull request Apr 29, 2022
@Narsil
Revert "Updating variable names. (#16445)" (#17011)
b8dffd1 
This reverts commit 4f3a14e.
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request May 3, 2022
@Narsil @stevhliu
Updating variable names. (huggingface#16445)
6fac074
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request May 3, 2022
@Narsil @stevhliu
Revert "Updating variable names. (huggingface#16445)" (huggingface#17011
4694766 
)

This reverts commit 4f3a14e.
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@Narsil @elusenji
Updating variable names. (huggingface#16445)
28a4ae8
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@Narsil @elusenji
Revert "Updating variable names. (huggingface#16445)" (huggingface#17011
b0158c5 
)

This reverts commit 4f3a14e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

+1 more reviewer

@sgugger sgugger sgugger left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Narsil @HuggingFaceDocBuilderDev @LysandreJik @sgugger