KEMBAR78
Remove duplicate header in doc by sgugger · Pull Request #16732 · huggingface/transformers · GitHub
Skip to content

Conversation

@sgugger
Copy link
Collaborator

@sgugger sgugger commented Apr 12, 2022

What does this PR do?

doc-builder doesn't accept duplicated headers anymore, this PR should fix the doc build. Will merge as soon as the Build Doc PR job is green to fix the main branch :-)

The change has been reverted on the doc-builder side, but this was a mistake worth fixing anyway.

These necessities imply several things developers should be careful about. These are detailed below.


### Implications
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redefined later in that file and that section is empty here, so I assume it's by mistake (cc @lewtun )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sgugger sgugger merged commit 0711c45 into main Apr 12, 2022
@sgugger sgugger deleted the deduplicate_doc branch April 12, 2022 16:37
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants