Kill async pushes when calling push_to_hub with blocking=True #16755
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
I think this is the right solution, but I wonder if we can't test it in a reproducible manner. Maybe we could do something like the following:
Now the first commit will likely fail with the error above. Unfortunately, this is likely a very heavy test, so I'm not sure it should be part of the CI. It can stil be used to test the validity of the solution above, though! |
LysandreJik
approved these changes
Apr 14, 2022
|
Actually @philschmid but let's say we are the same person ;-) |
|
For more context tested with |
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug that sometimes appear in the
Trainerwhenpush_to_hub=True: if one of the async pushes finishes after a regular non-async push, the history gets messed up and we end up with an error like this:To fix this, when the
Trainer(or the user) callspush_to_hubwithblocking=True, we interrupt any push in progress. The commit history will still be good since the commit don't take time.cc @philschmid who had the error.