KEMBAR78
CI: Create empty venv on cache miss by gante · Pull Request #16816 · huggingface/transformers · GitHub
Skip to content

Conversation

@gante
Copy link
Member

@gante gante commented Apr 18, 2022

What does this PR do?

Fixes a CI error introduced by #16789 -- when there was a cache miss, it attempted to initialize a virtual environment that didn't exist, in two CI workflows.

This PR fixes that by creating empty venvs on a cache miss.

(I wonder why the original CI run inside the PR didn't fail, the new cache names should have triggered the same error 🤔 )

@gante gante requested review from LysandreJik and sgugger April 18, 2022 10:46
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 18, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing! (Merging to fix the CI on main fast.

@sgugger sgugger merged commit 6984848 into huggingface:main Apr 18, 2022
@gante gante deleted the ci_venv_fix branch April 21, 2022 14:47
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants