TF: Add sigmoid activation function #16819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Apr 18, 2022
| "gelu_10": gelu_10, | ||
| "glu": glu, | ||
| "relu": tf.keras.activations.relu, | ||
| "sigmoid": tf.keras.activations.sigmoid, |
There was a problem hiding this comment.
the only new line (in practice)
gante
commented
Apr 18, 2022
| get_tf_activation("quick_gelu") | ||
| get_tf_activation("glu") | ||
| get_tf_activation("relu") | ||
| get_tf_activation("sigmoid") |
There was a problem hiding this comment.
and its corresponding test :)
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 18, 2022
|
As an aside, GELU is a core Keras activation now, although we might have to wait until we can move our minimum version before we can switch to using it instead of our own implementations. Other than that, this looks great! |
Rocketknight1
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #16810 -- adds the sigmoid activation function to the TF activation functions.
Also sorts the activation functions in the enum-like dict and in the tests, to quickly identify missing functions.