KEMBAR78
Fixing return type tensor with `num_return_sequences>1`. by Narsil · Pull Request #16828 · huggingface/transformers · GitHub
Skip to content

Fixing return type tensor with num_return_sequences>1. #16828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fixing return type tensor with num_return_sequences>1. #16828

merged 2 commits into from
Apr 20, 2022

Conversation

@Narsil
Copy link
Contributor

@Narsil Narsil commented Apr 19, 2022

What does this PR do?

Fixes #16796

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@patrickvonplaten
@LysandreJik

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil mentioned this pull request Apr 19, 2022
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 19, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

patrickvonplaten
patrickvonplaten reviewed Apr 19, 2022
View reviewed changes
FrankDataAnalystPython
FrankDataAnalystPython approved these changes Apr 20, 2022
View reviewed changes
Copy link

@FrankDataAnalystPython FrankDataAnalystPython left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results are correct!

@Narsil Narsil merged commit e13a91f into huggingface:main Apr 20, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@Narsil @elusenji
Fixing return type tensor with num_return_sequences>1. (huggingface…
21e3a3a 
…#16828)

* Fixing return type tensor with `num_return_sequences>1`.

* Nit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@FrankDataAnalystPython FrankDataAnalystPython FrankDataAnalystPython approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Small Bug: text2text_generation and text_generation result in duplicate results

4 participants

@Narsil @HuggingFaceDocBuilderDev @patrickvonplaten @FrankDataAnalystPython