Replace deprecated logger.warn with warning #16876
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
| setattr(quantizer_mod, k, v) | ||
| else: | ||
| logger.warn(f"{name} has no {quantizer}") | ||
| logger.warning(f"{name} has no {quantizer}") |
There was a problem hiding this comment.
Note that we don't actively maintain those ;-)
There was a problem hiding this comment.
Sure! Just covering all grounds!
| num_labels = kwargs.pop("num_labels", None) | ||
| if num_labels is not None and len(self.id2label) != num_labels: | ||
| logger.warn( | ||
| logger.warning( |
There was a problem hiding this comment.
I think that's our internal logger here no - not Python's logger. So not sure about this change @LysandreJik
There was a problem hiding this comment.
The logging module imported in this script is indeed our internal logging module that lives under the utils directory. We see here that the logger is instantiated by invoking the get_logger function from this module:
If we inspect the internal logging module in utils, we see that it first imports the Python logging module:
The
get_logger function simply returns the getLogger function from this Python logging module:transformers/src/transformers/utils/logging.py
Lines 113 to 124 in 72728be
Hence, our internal logger is implicitly derived from its parent Python logger, and is simply a wrapper for this module. Consequently, the advice regarding the use of warning in place of warn should still hold.
There was a problem hiding this comment.
Referring to @LysandreJik here :-)
4 participants
From Python docs:
There is an obsolete method
warnwhich is functionally identical towarning. Aswarnis deprecated, please do not use it - usewarninginstead.