Minor fixes/improvements in convert_file_size_to_int
#16891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
reviewed
Apr 22, 2022
src/transformers/modeling_utils.py
Outdated
| return int(size[:-2]) * (10**9) | ||
| if size.endswith("Gb"): | ||
| # gigabits | ||
| return int(size[:-2]) * (10**9 >> 3) |
There was a problem hiding this comment.
Not sure I understand this. This should be // 8 as 1 gigabyte = 8 gigabits. Also if we start supporting this, it should be the same for kilos and megas.
There was a problem hiding this comment.
Not sure I understand this. This should be
// 8as 1 gigabyte = 8 gigabits.
Yes, >> 3 does the same as // 8.
Also if we start supporting this, it should be the same for kilos and megas.
IMO it makes sense to be as precise as possible.
P.S. I did the same for kilos and megas.
|
The documentation is not available anymore as the PR was closed or merged. |
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…6891) * Minor improvements to `convert_file_size_to_int` * Add <unit>bit version to kilos and megas * Minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
convert_file_size_to_int's docstring example and the GB str to int conversion (per this comment by @lhoestq).