TF: XLA Logits Warpers #16899
Merged
TF: XLA Logits Warpers #16899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
approved these changes
Apr 23, 2022
gante
force-pushed
the
xla_logits_warper
branch
from
6f8b045 to
3ececfd
Compare
|
@patrickvonplaten Sorry, I know you've already reviewed this, but I'm going to re-request your review. I realized the tests were much easier to understand (and with fewer lines) if they were parametrized, instead of having two tests (one for XLA, another for non-XLA) with shared code 😅 |
gante
commented
Apr 24, 2022
|
|
||
| def _get_repetition_penalty_inputs(self): | ||
| @parameterized.expand([(False,), (True,)]) | ||
| def test_repetition_penalty_dist_process(self, use_xla): |
There was a problem hiding this comment.
changed this one from a two-test format (added in the previous PR) to the parametrized format
Rocketknight1
approved these changes
Apr 25, 2022
patrickvonplaten
approved these changes
Apr 25, 2022
Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables XLA on the logits warpers... which actually needed no changes. In essence, it adds XLA tests to ensure we don't regress.