KEMBAR78
Fix doc test quicktour dataset by patrickvonplaten · Pull Request #16929 · huggingface/transformers · GitHub
Skip to content

Conversation

@patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Apr 25, 2022

What does this PR do?

Makes sure that path of dataset is not returned.
See discussion: https://huggingface.slack.com/archives/C02CH2YP4EQ/p1650887822286239?thread_ts=1650816548.265789&cid=C02CH2YP4EQ

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten requested review from Narsil and sgugger and removed request for Narsil April 25, 2022 12:49
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 25, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickvonplaten patrickvonplaten merged commit 3a71e94 into huggingface:main Apr 25, 2022
@patrickvonplaten patrickvonplaten deleted the fix_doc_test_quicktour_dataset branch April 25, 2022 14:27
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
* fix doc test

* fix doc test

Co-authored-by: Patrick <patrick@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants