Fixup no_trainer save logic #16968
Merged
Fixup no_trainer save logic #16968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
added
PyTorch
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 27, 2022
chamidullinr
pushed a commit
to chamidullinr/transformers
that referenced
this pull request
Apr 28, 2022
* Fixup all examples
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Fixup all examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix save logic in all
no_trainerexamplesWhat does this add?
This PR fixes a bug pointed out in huggingface/accelerate#322, where the save and load logic was wrong in how it skipped over the steps in the training loop.
This PR fixes it and changes the internals slightly to let saveing of a checkpoint be named right (before it always started at
epoch_0, even if we resumed from epoch 1