KEMBAR78
Add translating guide by omarespejel · Pull Request #17004 · huggingface/transformers · GitHub
Skip to content

Conversation

@omarespejel
Copy link
Contributor

@omarespejel omarespejel commented Apr 29, 2022

What does this PR do?

Add a translation guide so users have all the information they need to (1) contribute to a language that's already being translated, or (2) start their own issue for translating into a new language.

Next step

Create a Translation Template for new issues (for example, this template for Portuguese with all the docs that should be translated). I can do this.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

* Next step would be to create a Translation Template for a new issues.
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 29, 2022

The documentation is not available anymore as the PR was closed or merged.

@omarespejel omarespejel requested a review from sgugger April 29, 2022 05:00
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! You should link to it from the main README of the docs folder.

@omarespejel
Copy link
Contributor Author

Thanks for the comments @sgugger!

I moved the _toctree.yml tip to a part where it would be more relevant. Please let me know if you would prefer it in another part 🤗

@sgugger
Copy link
Collaborator

sgugger commented Apr 29, 2022

LGTM!

@omarespejel omarespejel merged commit da47c26 into huggingface:main Apr 30, 2022
@omarespejel omarespejel deleted the add-translating-guide branch April 30, 2022 22:43
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request May 3, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants