KEMBAR78
Fix hashing for deduplication in CodeParrot by thomasw21 · Pull Request #17048 · huggingface/transformers · GitHub
Skip to content

Conversation

@thomasw21
Copy link
Contributor

What does this PR do?

Fix hashing mechanism to be process independent. Typically hash doesn't generate the same hash when using different process. So this makes the maximum number of occurence of a text to be num_proc instead of 1 when deduplicating.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@lvwerra @loubnabnl

@thomasw21 thomasw21 requested a review from lvwerra May 2, 2022 15:47
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! ❤️

@lvwerra lvwerra merged commit db03466 into main May 4, 2022
@lvwerra lvwerra deleted the thomas/fix_hashing_for_deduplication branch May 4, 2022 06:40
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants