Make the sacremoses dependency optional #17049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
approved these changes
May 2, 2022
| deps["pyyaml"], # used for the model cards metadata | ||
| deps["regex"], # for OpenAI GPT | ||
| deps["requests"], # for downloading models over HTTPS | ||
| deps["sacremoses"], # for XLM |
|
The documentation is not available anymore as the PR was closed or merged. |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
May 3, 2022
* Make sacremoses optional * Pickle
4 tasks
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* Make sacremoses optional * Pickle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sacremoses is currently installed by default when installing
transformers, but it should not be needed. This is an artifact of the past, and we have since introduced optional dependencies, which applies perfectly to this situation.