KEMBAR78
Allow all imports from transformers by LysandreJik · Pull Request #17050 · huggingface/transformers · GitHub
Skip to content

Conversation

@LysandreJik
Copy link
Member

This PR enables doing from transformers import * when just the base transformers install is done. This should always have been possible, but due to some errors in the imports, it currently failed with a sentencepiece import error. This PR fixes that for both the FNet and CPM tokenizers.

@LysandreJik LysandreJik requested a review from sgugger May 2, 2022 16:36
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the cleanup! This was long overdue!

@LysandreJik LysandreJik merged commit bb2e088 into main May 2, 2022
@LysandreJik LysandreJik deleted the sentencepiece-optional branch May 2, 2022 16:47
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 2, 2022

The documentation is not available anymore as the PR was closed or merged.

stevhliu pushed a commit to stevhliu/transformers that referenced this pull request May 3, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants