KEMBAR78
Fix MLflowCallback and add support for MLFLOW_EXPERIMENT_NAME by orieg · Pull Request #17091 · huggingface/transformers · GitHub
Skip to content

Fix MLflowCallback and add support for MLFLOW_EXPERIMENT_NAME #17091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2022
Merged

Fix MLflowCallback and add support for MLFLOW_EXPERIMENT_NAME #17091

merged 2 commits into from
May 5, 2022

Conversation

@orieg
Copy link
Contributor

@orieg orieg commented May 4, 2022

What does this PR do?

This PR includes the following:

Supersedes #17067 due to CI build errors.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger

@orieg orieg mentioned this pull request May 4, 2022
Closed
5 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 4, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Collaborator

sgugger commented May 5, 2022

Managed to activate the test by checking out your PR and pushing it to a new branch in the transformers namespace. I have no idea why it worked.

Anyhow, please run make style on your branch to fix the code quality issue and we should be good to merge! (you'll need to install the latest versions of our deps for styling with pip install .[quality] -U )

@orieg
Copy link
Contributor Author

orieg commented May 5, 2022

@sgugger All checks passed! 🤗

@sgugger
Copy link
Collaborator

sgugger commented May 5, 2022

Thanks a lot!

@sgugger sgugger merged commit c849a61 into huggingface:main May 5, 2022
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
@orieg @elusenji
Fix MLflowCallback and add support for MLFLOW_EXPERIMENT_NAME (huggin…
58a15d1 
…gface#17091)

* Fix use of mlflow.active_run() and add proper support for MLFLOW_EXPERIMENT_NAME

* Fix code style (make style)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect check for MLFlow active run in MLflowCallback Set Experiment Name in MLflowCallback

3 participants

@orieg @HuggingFaceDocBuilderDev @sgugger