KEMBAR78
Remove torchhub test by sgugger · Pull Request #17097 · huggingface/transformers · GitHub
Skip to content

Conversation

@sgugger
Copy link
Collaborator

@sgugger sgugger commented May 5, 2022

What does this PR do?

The torchhub test is failing with a cryptic error. This PR removes the test but keeps the integration intact. As the Hugging Face Hub becomes the main marketplace for transformers models, it should be the integration users use and while torchhub remains supported we will not test it going forward.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgugger sgugger merged commit dd16a11 into main May 5, 2022
@sgugger sgugger deleted the no_torch_hub branch May 5, 2022 14:02
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@julien-c
Copy link
Member

julien-c commented May 6, 2022

😭😭

elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants