propagate "attention_mask" dtype for "use_past" in OnnxConfig.generate_dummy_inputs #17105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lewtun
approved these changes
May 6, 2022
There was a problem hiding this comment.
Thanks for improving all these types for the attention masks @arampacha!
It looks good to me, so gently pinging @patil-suraj and @sgugger for their perspective :)
For context to the reviewers: these changes ensure the data types of input_ids and attention_mask are the same (i.e. ints) when these models are exported to ONNX
ArthurZucker
pushed a commit
to ArthurZucker/transformers
that referenced
this pull request
May 12, 2022
…e_dummy_inputs (huggingface#17105) * propagate attention_mask dtype * fixup&style
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…e_dummy_inputs (huggingface#17105) * propagate attention_mask dtype * fixup&style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #16538
The
mask_dtypeis propagated totorch.ones()producing "attention_mask" forpast_key_valuesingenerate_dummy_inputscall. This ensures the input datatype expected by ONNX model matches default "attention_mask"dtype.The fix is applied for configs where the pattern was used.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
The existing tests use
*OnnxConfig.generate_dummy_inputsmethod to produce inputs passed tosession.run(...)for testing. For this reason the issue was not reported at testing - the same inputs are used for export and testing. I'm not sure if specific tests for inputs datatype is required.Here is a notebook for verifying the fix works as expected.
Who can review?
@lewtun