[trainer] sharded _load_best_model #17150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably needs a test?
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 10, 2022
|
Thank you for explaining why the testing of this path is complicated, Sylvain. I think I can make it partially tested by using zero3 w/o |
ArthurZucker
pushed a commit
to ArthurZucker/transformers
that referenced
this pull request
May 12, 2022
* [trainer] sharded _load_best_model probably needs a test? * undo delete
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
* [trainer] sharded _load_best_model probably needs a test? * undo delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a copy-in-paste issue. This code path is probably untested.
@sgugger