KEMBAR78
Extend Transformers Trainer Class to Enable PyTorch SGD/Adagrad Optimizers for Training by jianan-gu · Pull Request #17154 · huggingface/transformers · GitHub
Skip to content

Conversation

@jianan-gu
Copy link
Contributor

What does this PR do?

This PR intends to extend Transformers Trainer Class with two PyTorch common optimizer algorithms, SGD and Adagrad , for model training.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 10, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those!

Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding those, @jianan-gu

(after Sylvain's proposal)

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
@sgugger sgugger merged commit 0e6ec2a into huggingface:main May 11, 2022
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request May 12, 2022
…izers for Training (huggingface#17154)

* add torch SGD and Adagrad optimizer bits

* refine naming

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
…izers for Training (huggingface#17154)

* add torch SGD and Adagrad optimizer bits

* refine naming

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants