KEMBAR78
remove `triton_kernels` dep with `kernels` instead by SunMarc · Pull Request #39926 · huggingface/transformers · GitHub
Skip to content

Conversation

@SunMarc
Copy link
Member

@SunMarc SunMarc commented Aug 5, 2025

What does this PR do?

This PR remove triton_kernels dependency with kernels instead when using the new oai model gpt-oss

@SunMarc SunMarc changed the title remove dep remove triton_kernels dep with kernels instead Aug 5, 2025
@SunMarc SunMarc requested a review from ArthurZucker August 5, 2025 17:08
@SunMarc SunMarc requested a review from MekkCyber August 6, 2025 13:00
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ! Thanks for porting the kernels to the hub! Left a small nit

@Ree1s
Copy link

Ree1s commented Aug 6, 2025

Hi, may I ask why I can't find triton_kernels in kernels-community?

@SunMarc
Copy link
Member Author

SunMarc commented Aug 6, 2025

Hi, may I ask why I can't find triton_kernels in kernels-community?

It is still private, it will switch it to public after this is merged !

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: mxfp4

@SunMarc SunMarc merged commit 6902ffa into main Aug 6, 2025
25 checks passed
@SunMarc SunMarc deleted the remove-dep branch August 6, 2025 17:31
@SunMarc SunMarc added the for patch Tag issues / labels that should be included in the next patch label Aug 6, 2025
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just missing some doc but lGTM

ArthurZucker pushed a commit that referenced this pull request Aug 13, 2025
* remove dep

* style

* rm import

* fix

* style

* simplify

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for patch Tag issues / labels that should be included in the next patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants