KEMBAR78
Revert "fix `notification_service.py` about `time_spent`" by ydshieh · Pull Request #40044 · huggingface/transformers · GitHub
Skip to content

Revert "fix notification_service.py about time_spent" #40044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

Revert "fix notification_service.py about time_spent" #40044

merged 1 commit into from
Aug 8, 2025

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 8, 2025 •
edited
Loading

Reverts #40037

There were some edge case errors not detected until a full run was triggered

https://github.com/huggingface/transformers/actions/runs/16833364235/job/47693598035

  File "/home/runner/work/transformers/transformers/utils/notification_service.py", line 206, in time
    hours, minutes, seconds = int(time_parts[0]), int(time_parts[1]), float(time_parts[2])
ValueError: invalid literal for int() with base 10: '(0'

revert for now to avoid next daily CI failing to produce reports.

Will check and fix later.

@ydshieh ydshieh merged commit f4d57f2 into main Aug 8, 2025
15 checks passed
@ydshieh ydshieh deleted the revert-40037-fix_time_spent branch August 8, 2025 20:32
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ydshieh @HuggingFaceDocBuilderDev