KEMBAR78
fix `notification_service.py` about `time_spent` by ydshieh · Pull Request #40037 · huggingface/transformers · GitHub
Skip to content

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 8, 2025

What does this PR do?

We extract the information from test report file like in 1 passed in 7.89s, but at some point, we do

... ["time_spent"] += time_spent[1:-1]

which remove the first digit. I am not guility!

matrix_job_results[matrix_name]["errors"] += errors
matrix_job_results[matrix_name]["skipped"] += skipped
matrix_job_results[matrix_name]["time_spent"] += time_spent[1:-1] + ", "
matrix_job_results[matrix_name]["time_spent"] += time_spent[:-1] + ", "
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not my bad !

@ydshieh ydshieh requested review from ivarflakstad and remi-or August 8, 2025 14:58
Copy link
Collaborator

@remi-or remi-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe formatting changed since the code was written?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 8, 2025

Maybe formatting changed since the code was written?

or maybe it's just wrong even before I join HF 👀 won't try to figure it out

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh merged commit d2ba153 into main Aug 8, 2025
13 of 15 checks passed
@ydshieh ydshieh deleted the fix_time_spent branch August 8, 2025 15:11
ydshieh added a commit that referenced this pull request Aug 8, 2025
ydshieh added a commit that referenced this pull request Aug 8, 2025
Revert "fix `notification_service.py` about `time_spent` (#40037)"

This reverts commit d2ba153.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants