KEMBAR78
Fix config dtype parsing for Emu3 edge case by Isotr0py · Pull Request #40766 · huggingface/transformers · GitHub
Skip to content

Fix config dtype parsing for Emu3 edge case #40766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2025
Merged

Fix config dtype parsing for Emu3 edge case #40766

merged 3 commits into from
Sep 11, 2025

Conversation

@Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Sep 9, 2025 •
edited
Loading

What does this PR do?

Fixes vllm-project/vllm#24447 (comment)

  • "dtype" is one of token in Emu3Config's vocabulary_map, so current config dtype parsing logic can run into issue for vocab_map {'dtype': 47727}.
  • This PR makes the dtype parsing logic more robust.

Reproduction code

from transformers import AutoConfig

config = AutoConfig.from_pretrained("BAAI/Emu3-Chat-hf")
print(config)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Isotr0py
fix emu3 config
cdbf891 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Isotr0py Isotr0py mentioned this pull request Sep 9, 2025
Merged
5 tasks
zucchini-nlp
zucchini-nlp reviewed Sep 10, 2025
View reviewed changes
@Isotr0py
address comment
a47fe4f 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
zucchini-nlp
zucchini-nlp approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm. Maybe add a comment explaining why it is needed so we don't accidentally remove it in the future and we can merge

Approving in advance

@Isotr0py
add comments
8e99adc 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@zucchini-nlp zucchini-nlp enabled auto-merge (squash) September 11, 2025 08:19
@zucchini-nlp zucchini-nlp merged commit 02f1d7c into huggingface:main Sep 11, 2025
23 checks passed
@Isotr0py Isotr0py deleted the fix-emu3-config branch September 11, 2025 08:34
@ArthurZucker ArthurZucker added the for patch Tag issues / labels that should be included in the next patch label Sep 12, 2025
LysandreJik pushed a commit that referenced this pull request Sep 17, 2025
@Isotr0py @LysandreJik
Fix config dtype parsing for Emu3 edge case (#40766)
a55e503 
* fix emu3 config

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

* address comment

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

* add comments

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

---------

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
vijayabhaskar-ev pushed a commit to vijayabhaskar-ev/transformers that referenced this pull request Oct 2, 2025
@Isotr0py @vijayabhaskar-ev
Fix config dtype parsing for Emu3 edge case (huggingface#40766)
26b0de9 
* fix emu3 config

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

* address comment

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

* add comments

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

---------

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Oct 4, 2025
@Isotr0py @yuchenxie4645
Fix config dtype parsing for Emu3 edge case (huggingface#40766)
ef3cc80 
* fix emu3 config

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

* address comment

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

* add comments

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>

---------

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zucchini-nlp zucchini-nlp zucchini-nlp approved these changes

Assignees

No one assigned

Labels

for patch Tag issues / labels that should be included in the next patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Isotr0py @HuggingFaceDocBuilderDev @zucchini-nlp @ArthurZucker