Fix trainer for py3.9 #41359
Merged
Fix trainer for py3.9 #41359
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunMarc
added
the
for patch
Cyrilvallez
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
I just merged #41268 on main, if you prefer ton only add it on the v4 branch.
No strong opinion though, we can merge on main as well since it's only typing!
|
For this one, let's merge on main and cherry pick it on v4 branch as this is just typing ! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
5 tasks
|
Can you close this issue #41339 after merge? |
4 tasks
AhnJoonSung
pushed a commit
to AhnJoonSung/transformers
that referenced
this pull request
Oct 12, 2025
Cyrilvallez
pushed a commit
that referenced
this pull request
Oct 14, 2025
|
Hi, this one was my bad! We've been updating for Py3.10 because Py3.9 is EOL next week. Do we really want to revert to support it? |
|
Don't worry @Rocketknight1, it was for a patch that was released last week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes trainer compatibility with py3.9. To be added in a patch for the latest release. Asked by optimum folks cc @IlyasMoutawwakil