KEMBAR78
[DPO] TR-DPO gather the target model params as well when syncing by kashif · Pull Request #1978 · huggingface/trl · GitHub
Skip to content

Conversation

@kashif
Copy link
Collaborator

@kashif kashif commented Aug 26, 2024

What does this PR do?

fixes #1971

@kashif kashif requested a review from lewtun August 26, 2024 18:08
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@kashif kashif merged commit a15a80e into huggingface:main Aug 28, 2024
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TR-DPO bug

3 participants