KEMBAR78
Fix flaky Hub tests by lewtun · Pull Request #1981 · huggingface/trl · GitHub
Skip to content

Conversation

@lewtun
Copy link
Member

@lewtun lewtun commented Aug 27, 2024

What does this PR do?

Fixes flaky tests with Hub timeouts by enabling a rerun mechanism. See internal Slack thread: https://huggingface.slack.com/archives/C02EMARJ65P/p1718635566000569?thread_ts=1718631080.742169&cid=C02EMARJ65P

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lewtun lewtun requested review from kashif and qgallouedec August 27, 2024 07:43
@kashif kashif merged commit b65657f into main Aug 27, 2024
@kashif kashif deleted the fix-flaky-tests branch August 27, 2024 08:14
@lewtun lewtun mentioned this pull request Aug 27, 2024
5 tasks
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
* Fix flaky Hub tests

* Trigger Build

* test buld
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants