Inverted composition disabled flag to be composition enabled #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Feb 8, 2021
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Feb 9, 2021
https://bugs.webkit.org/show_bug.cgi?id=221599 Patch by Imanol Fernandez <ifernandez@igalia.com> on 2021-02-09 Reviewed by Sergio Villar Senin. The spec agreed to rename this to avoid double negations in code. See immersive-web/webxr#1172. * Modules/webxr/WebXRWebGLLayer.cpp: (WebCore::WebXRWebGLLayer::create): (WebCore::WebXRWebGLLayer::WebXRWebGLLayer): * Modules/webxr/WebXRWebGLLayer.h: Canonical link: https://commits.webkit.org/233843@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
bertogg
pushed a commit
to Igalia/webkit
that referenced
this pull request
Feb 9, 2021
https://bugs.webkit.org/show_bug.cgi?id=221599 Patch by Imanol Fernandez <ifernandez@igalia.com> on 2021-02-09 Reviewed by Sergio Villar Senin. The spec agreed to rename this to avoid double negations in code. See immersive-web/webxr#1172. * Modules/webxr/WebXRWebGLLayer.cpp: (WebCore::WebXRWebGLLayer::create): (WebCore::WebXRWebGLLayer::WebXRWebGLLayer): * Modules/webxr/WebXRWebGLLayer.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@272571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1171
The fact that this was phrased as "disabled" was a historical artifact left over from a point when the flag was going to be exposed as part of the API surface and we wanted it to default to
false.Preview | Diff