requestSession: Check for user activation first #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications should not be able to obtain any additional information without user activation.
NellWaliczek
approved these changes
Jun 5, 2019
ddorwin
added a commit
to ddorwin/webxr
that referenced
this pull request
Jun 17, 2019
After immersive-web#685, there is only one failure path at this point, and these steps can be simplified. This also addresses incorrectly rejecting with `null`.
toji
pushed a commit
that referenced
this pull request
Jun 17, 2019
After #685, there is only one failure path at this point, and these steps can be simplified. This also addresses incorrectly rejecting with `null`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications should not be able to obtain any additional information without user activation.