Remove context Attribute from XRWebGLLayer #699
Conversation
I have no idea what I'm doing so I'll explain what I did. I made what seemed like the obvious change in index.bs and tried to find any other references in the file. I searched through the explainer to see if it needed changes and it didn't seem to. I also checked a few of the code samples and they also don't seem to us this attribute.
There was a problem hiding this comment.
Yay for new helpers! Thanks for putting this together, Brice! The changes in the index.bs look correct to me. There is one change that needs to be made in the idl section of the explainer.md. The following line needs to be removed:
readonly attribute XRWebGLRenderingContext context;
|
doh! forgot about that one. Will fix soon.
…On Fri, Jun 14, 2019 at 8:24 AM Nell Waliczek ***@***.***> wrote:
***@***.**** commented on this pull request.
Yay for new helpers! Thanks for putting this together, Brice! The changes
in the index.bs look correct to me. There is one change that needs to be
made in the idl section of the explainer.md. The following line needs to be
removed:
readonly attribute XRWebGLRenderingContext context;
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#699?email_source=notifications&email_token=AADQUWIYIDUKCSA22VATYA3P2OZ4HA5CNFSM4HYIUET2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3TDVCI#pullrequestreview-249969289>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADQUWKMVKCLWBLI6CKUZ5TP2OZ4HANCNFSM4HYIUETQ>
.
|
|
Yes, thanks for the help, Brice! There's a few references that you missed in the spec doc as well: Basically just do a search for This means simply that you'll want to add some text to the
At which point you can do a straight replacement of I highly recommend running |
…mmersive-web#701) Replace 'list of pending render states' with 'pending render state'
Fixes immersive-web#693. Also removed two lines of error checking that are now redundant.
I have no idea what I'm doing so I'll explain what I did. I made what seemed like the obvious change in index.bs and tried to find any other references in the file. I searched through the explainer to see if it needed changes and it didn't seem to. I also checked a few of the code samples and they also don't seem to us this attribute.
|
Closing this in favor of #707 |
4 participants
I have no idea what I'm doing so I'll explain what I did. I made what seemed like the obvious change in index.bs and tried to find any other references in the file. I searched through the explainer to see if it needed changes and it didn't seem to. I also checked a few of the code samples and they also don't seem to us this attribute.