KEMBAR78
data/templates/default.beamer: only emit \date if set by josch · Pull Request #10687 · jgm/pandoc · GitHub
Skip to content

Conversation

@josch
Copy link
Contributor

@josch josch commented Mar 13, 2025

This allows one, for example, to set a custom \date in the header-includes of the rmarkdown yaml frontmatter. Without this conditional, the custom \date in the frontmatter would be overridden by a (potentially empty) date from this template later.

This allows one, for example, to set a custom \date in the
header-includes of the rmarkdown yaml frontmatter. Without this
conditional, the custom \date in the frontmatter would be overridden by
a (potentially empty) date from this template later.
@jgm jgm merged commit 3f1f58e into jgm:main Mar 15, 2025
11 of 14 checks passed
@jgm
Copy link
Owner

jgm commented Mar 15, 2025

thanks!

@jgm
Copy link
Owner

jgm commented Mar 17, 2025

This is being reverted. The commit reverting it will include an explanation.

jgm added a commit that referenced this pull request Mar 17, 2025
This reverts commit 3f1f58e.

The reason for reverting this change is that it led to an
undesirable behavior change. Documents with no explicit date
specified now have a date printed, because the default
title block will include a date if no `\date` command is used.
The empty `\date{}`, by contrast, suppressed the date, which
is the desirable behavior.

PR #10687 was motivated by the desire to include a custom `\date`
in the frontmatter via header-includes.  I think that aim can
be achieved more simply by simply setting the `date` variable.
In markdown you can even use `date:` in metadata and put some
raw LaTeX there.
@josch
Copy link
Contributor Author

josch commented Mar 17, 2025

This is being reverted. The commit reverting it will include an explanation.

Thank you for fixing the problem my change introduced and sorry for the extra work my PR caused. Thank you for maintaining pandoc! ❤️

@jgm
Copy link
Owner

jgm commented Mar 17, 2025

No worries, thanks anyway for the contribution!

massifrg pushed a commit to massifrg/pandoc that referenced this pull request May 7, 2025
This allows one, for example, to set a custom \date in the
header-includes of the rmarkdown yaml frontmatter. Without this
conditional, the custom \date in the frontmatter would be overridden by
a (potentially empty) date from this template later.
massifrg pushed a commit to massifrg/pandoc that referenced this pull request May 7, 2025
This reverts commit 3f1f58e.

The reason for reverting this change is that it led to an
undesirable behavior change. Documents with no explicit date
specified now have a date printed, because the default
title block will include a date if no `\date` command is used.
The empty `\date{}`, by contrast, suppressed the date, which
is the desirable behavior.

PR jgm#10687 was motivated by the desire to include a custom `\date`
in the frontmatter via header-includes.  I think that aim can
be achieved more simply by simply setting the `date` variable.
In markdown you can even use `date:` in metadata and put some
raw LaTeX there.
christopherkenny pushed a commit to christopherkenny/pandoc that referenced this pull request May 23, 2025
This allows one, for example, to set a custom \date in the
header-includes of the rmarkdown yaml frontmatter. Without this
conditional, the custom \date in the frontmatter would be overridden by
a (potentially empty) date from this template later.
christopherkenny pushed a commit to christopherkenny/pandoc that referenced this pull request May 23, 2025
This reverts commit 3f1f58e.

The reason for reverting this change is that it led to an
undesirable behavior change. Documents with no explicit date
specified now have a date printed, because the default
title block will include a date if no `\date` command is used.
The empty `\date{}`, by contrast, suppressed the date, which
is the desirable behavior.

PR jgm#10687 was motivated by the desire to include a custom `\date`
in the frontmatter via header-includes.  I think that aim can
be achieved more simply by simply setting the `date` variable.
In markdown you can even use `date:` in metadata and put some
raw LaTeX there.
christopherkenny pushed a commit to christopherkenny/pandoc that referenced this pull request May 23, 2025
This allows one, for example, to set a custom \date in the
header-includes of the rmarkdown yaml frontmatter. Without this
conditional, the custom \date in the frontmatter would be overridden by
a (potentially empty) date from this template later.
christopherkenny pushed a commit to christopherkenny/pandoc that referenced this pull request May 23, 2025
This reverts commit 3f1f58e.

The reason for reverting this change is that it led to an
undesirable behavior change. Documents with no explicit date
specified now have a date printed, because the default
title block will include a date if no `\date` command is used.
The empty `\date{}`, by contrast, suppressed the date, which
is the desirable behavior.

PR jgm#10687 was motivated by the desire to include a custom `\date`
in the frontmatter via header-includes.  I think that aim can
be achieved more simply by simply setting the `date` variable.
In markdown you can even use `date:` in metadata and put some
raw LaTeX there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants