Support for more Dadaptation #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works well.Even i try to use DAdaptAdan for block weight lr.... |
kohya-ss
reviewed
Apr 27, 2023
There was a problem hiding this comment.
get_optimizer method looks like it would be better to refactor to make some parts common. If it is difficult to deal with, I will update it after the merge.
|
Thank you for this! I will take a look when I have time! |
|
I found something interesting——pytorch_optimizer |
|
Thank you for this! I've merged. Sorry for the delay.
|
wkpark
pushed a commit
to wkpark/sd-scripts
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more optimizer_type for DAdaptation
DAdaptation(DAdaptAdam)
DAdaptAdaGrad
DAdaptAdan
DAdaptSGD
i will test tomorrow