KEMBAR78
fix dirty commit version by medyagh · Pull Request #21062 · kubernetes/minikube · GitHub
Skip to content

fix dirty commit version #21062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2025
Merged

fix dirty commit version #21062

merged 3 commits into from
Jul 14, 2025

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Jul 13, 2025 •
edited
Loading

Before This PR (doesnt fail)

$ ./dirt.sh 
minikube version: v1.36.0 commit: 81c6d3b625553d20e310b911b70eafd781fbf708-dirty

After this PR

minikube version: v1.36.0
commit: 81c6d3b625553d20e310b911b70eafd781fbf708-dirty
'minikube version' reports dirty commit: 81c6d3b625553d20e310b911b70eafd781fbf708-dirty
------------------------------------------------------------------------
The following uncommitted changes are causing the build to be dirty:
 M hack/jenkins/release_build_and_upload.sh
?? dirt.sh
------------------------------------------------------------------------
To fix this, commit or stash the above changes.

closes #20930

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh changed the title fix version Dirty commit fix dirty commit version Jul 14, 2025
@medyagh medyagh merged commit 7d8d974 into kubernetes:master Jul 14, 2025
6 of 7 checks passed
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Aug 18, 2025
@medyagh @pavansaikrishna78
fix dirty commit version (kubernetes#21062)
5ed03e8 
* fix release script detecting dirty commit

* add go-licenses to gitignore

* add more help text
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Sep 9, 2025
@medyagh @pavansaikrishna78
fix dirty commit version (kubernetes#21062)
a0488ae 
* fix release script detecting dirty commit

* add go-licenses to gitignore

* add more help text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@prezha prezha Awaiting requested review from prezha

1 more reviewer

@tstromberg tstromberg tstromberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Dirty-commit in "Version"

3 participants

@medyagh @k8s-ci-robot @tstromberg