KEMBAR78
Fix mount to same folder causing Input/output error by medyagh · Pull Request #21077 · kubernetes/minikube · GitHub
Skip to content

Fix mount to same folder causing Input/output error #21077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

Fix mount to same folder causing Input/output error #21077

merged 1 commit into from
Jul 17, 2025

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Jul 16, 2025 •
edited
Loading

Before this PR

check #21076

After this PR

killing mount and mounting to the same folder wont break


$ ./out/minikube mount ~/.asdf/:/tmp4
📁  Mounting host path /Users/medya/.asdf/ into VM as /tmp4 ...
    ▪ Mount type:   9p
    ▪ User ID:      docker
    ▪ Group ID:     docker
    ▪ Version:      9p2000.L
    ▪ Message Size: 262144
    ▪ Options:      map[]
    ▪ Bind Address: 192.168.106.1:61318
🚀  Userspace file server: ufs starting
✅  Successfully mounted /Users/medya/.asdf/ to /tmp4

📌  NOTE: This process must stay alive for the mount to be accessible ...
^C🔥  Unmounting /tmp4 ...

❌  Exiting due to MK_INTERRUPTED: Received interrupt signal

12:42:24 medya/workspace/minikube
mount •2
$ ./out/minikube mount ~/.asdf/:/tmp4
📁  Mounting host path /Users/medya/.asdf/ into VM as /tmp4 ...
    ▪ Mount type:   9p
    ▪ User ID:      docker
    ▪ Group ID:     docker
    ▪ Version:      9p2000.L
    ▪ Message Size: 262144
    ▪ Options:      map[]
    ▪ Bind Address: 192.168.106.1:61326
🚀  Userspace file server: ufs starting
✅  Successfully mounted /Users/medya/.asdf/ to /tmp4

📌  NOTE: This process must stay alive for the mount to be accessible ...
^C🔥  Unmounting /tmp4 ...

❌  Exiting due to MK_INTERRUPTED: Received interrupt signal

12:42:46 medya/workspace/minikube
mount •2
$ ./out/minikube mount ~/.asdf/:/tmp4
📁  Mounting host path /Users/medya/.asdf/ into VM as /tmp4 ...
    ▪ Mount type:   9p
    ▪ User ID:      docker
    ▪ Group ID:     docker
    ▪ Version:      9p2000.L
    ▪ Message Size: 262144
    ▪ Options:      map[]
    ▪ Bind Address: 192.168.106.1:61330
🚀  Userspace file server: ufs starting
✅  Successfully mounted /Users/medya/.asdf/ to /tmp4

📌  NOTE: This process must stay alive for the mount to be accessible ...
^C🔥  Unmounting /tmp4 ...

❌  Exiting due to MK_INTERRUPTED: Received interrupt signal

closes #21076

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2025
@medyagh
Copy link
Member Author

medyagh commented Jul 16, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ComradeProgrammer,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh changed the title use lazy unmounting to detach the filesystem now, clean up things later Fix mounting to same folder causing issue "Input/output error" Jul 16, 2025
@medyagh medyagh changed the title Fix mounting to same folder causing issue "Input/output error" Fix mount-ing to same folder causing issue "Input/output error" Jul 16, 2025
@medyagh medyagh changed the title Fix mount-ing to same folder causing issue "Input/output error" Fix mount-ing to same folder causing Input/output error Jul 16, 2025
@medyagh medyagh changed the title Fix mount-ing to same folder causing Input/output error Fix mount to same folder causing Input/output error Jul 16, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 21077) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 50.8s               |
| enable ingress | 14.9s    | 15.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.8s 51.6s 49.9s 48.1s 53.5s
Times for minikube (PR 21077) start: 51.5s 48.7s 49.8s 49.1s 54.8s

Times for minikube ingress: 14.5s 15.0s 14.5s 15.5s 14.9s
Times for minikube (PR 21077) ingress: 15.0s 15.0s 15.0s 15.0s 15.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 21077) |
+----------------+----------+---------------------+
| minikube start | 25.7s    | 23.8s               |
| enable ingress | 13.3s    | 13.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 21077) ingress: 12.3s 13.8s 13.3s 12.8s 12.8s
Times for minikube ingress: 13.8s 13.3s 12.8s 13.3s 13.3s

Times for minikube start: 25.1s 24.0s 27.5s 25.9s 26.2s
Times for minikube (PR 21077) start: 24.4s 23.1s 21.9s 26.7s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 21077) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 22.6s               |
| enable ingress | 29.9s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube start: 24.6s 22.0s 21.5s 22.1s 25.8s
Times for minikube (PR 21077) start: 26.1s 21.1s 22.5s 21.7s 21.4s

Times for minikube ingress: 23.8s 40.3s 23.8s 38.8s 22.8s
Times for minikube (PR 21077) ingress: 22.8s 22.8s 22.8s 22.8s 23.8s

@medyagh medyagh merged commit 185285e into kubernetes:master Jul 17, 2025
39 of 46 checks passed
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Aug 18, 2025
@medyagh @pavansaikrishna78
use lazy unmounting to detach the filesystem now, clean up things lat…
0afcbdf 
…er (kubernetes#21077)
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Sep 9, 2025
@medyagh @pavansaikrishna78
use lazy unmounting to detach the filesystem now, clean up things lat…
8fae432 
…er (kubernetes#21077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer ComradeProgrammer approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mount: after closing "minikube mount" can not re-mount to same destination

4 participants

@medyagh @k8s-ci-robot @minikube-pr-bot @ComradeProgrammer