KEMBAR78
improve docker service reliability, update docker systemd files by ComradeProgrammer · Pull Request #21174 · kubernetes/minikube · GitHub
Skip to content

improve docker service reliability, update docker systemd files #21174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2025
Merged

improve docker service reliability, update docker systemd files #21174

merged 3 commits into from
Aug 9, 2025

Conversation

@ComradeProgrammer
Copy link
Member

Previous docker.service file generated by minikube is too old, and it does not wait for the containerd. This pr will update the docker.service according to the latest one.

@k8s-ci-robot k8s-ci-robot requested a review from medyagh July 28, 2025 15:54
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2025
@k8s-ci-robot k8s-ci-robot requested a review from prezha July 28, 2025 15:54
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2025
@medyagh
Copy link
Member

medyagh commented Jul 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 28, 2025
medyagh
medyagh reviewed Jul 28, 2025
View reviewed changes
medyagh
medyagh requested changes Jul 28, 2025
View reviewed changes
medyagh
medyagh reviewed Jul 28, 2025
View reviewed changes
nirs
nirs reviewed Jul 28, 2025
View reviewed changes
Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the smoke tests green!

@minikube-pr-bot

This comment has been minimized.

Sign in to view
medyagh
medyagh requested changes Aug 5, 2025
View reviewed changes
@ComradeProgrammer
Copy link
Member Author

/ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @ComradeProgrammer, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 5, 2025
@minikube-pr-bot

This comment has been minimized.

Sign in to view
medyagh
medyagh requested changes Aug 5, 2025
View reviewed changes
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2025
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@medyagh
Copy link
Member

medyagh commented Aug 9, 2025

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21174 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 49.2s    │ 48.1s                  │
│ enable ingress │ 15.1s    │ 14.8s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 50.6s 49.0s 49.9s 46.6s 49.8s
Times for minikube (PR 21174) start: 44.6s 47.6s 50.6s 48.9s 48.7s

Times for minikube ingress: 14.9s 14.9s 15.9s 15.0s 15.0s
Times for minikube (PR 21174) ingress: 15.4s 14.4s 15.4s 14.4s 14.4s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21174 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.3s    │ 23.4s                  │
│ enable ingress │ 13.1s    │ 13.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 21.8s 25.6s 22.6s 25.0s 21.3s
Times for minikube (PR 21174) start: 23.1s 23.4s 22.8s 25.5s 22.2s

Times for minikube (PR 21174) ingress: 12.8s 13.3s 13.8s 13.8s 13.8s
Times for minikube ingress: 13.2s 12.8s 12.8s 13.8s 12.8s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21174 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.7s    │ 23.3s                  │
│ enable ingress │ 23.0s    │ 26.7s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 22.3s 21.7s 20.5s 20.1s 23.8s
Times for minikube (PR 21174) start: 24.0s 22.7s 24.4s 21.5s 24.1s

Times for minikube ingress: 22.8s 23.3s 22.8s 23.3s 22.8s
Times for minikube (PR 21174) ingress: 24.3s 23.8s 22.8s 23.2s 39.3s

@medyagh
Copy link
Member

medyagh commented Aug 9, 2025

thank you @ComradeProgrammer I think this is gonna improve the experience of minikube and reduce flakes
I check the Docker_linux Test Duration didnt change still around 47 minutes, so it is probably not affecting performance either

@medyagh medyagh changed the title docker: update template for docker.service improve docker service reliability, update docker systemd files Aug 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ComradeProgrammer,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit d0a21be into kubernetes:master Aug 9, 2025
27 of 37 checks passed
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Aug 11, 2025
@ComradeProgrammer @pavansaikrishna78
improve docker service reliability, update docker systemd files (kube…
27bb90b 
…rnetes#21174)

* docker: update template for docker.service

* wait for docker

* fix unit test
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Aug 18, 2025
@ComradeProgrammer @pavansaikrishna78
improve docker service reliability, update docker systemd files (kube…
a833fc0 
…rnetes#21174)

* docker: update template for docker.service

* wait for docker

* fix unit test
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Sep 9, 2025
@ComradeProgrammer @pavansaikrishna78
improve docker service reliability, update docker systemd files (kube…
2407240 
…rnetes#21174)

* docker: update template for docker.service

* wait for docker

* fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh approved these changes

@prezha prezha Awaiting requested review from prezha

+1 more reviewer

@nirs nirs nirs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ComradeProgrammer @medyagh @minikube-pr-bot @minikube-bot @k8s-ci-robot @nirs