KEMBAR78
UI: do not show "create github issue" twice if kubeadm init fails by medyagh · Pull Request #21263 · kubernetes/minikube · GitHub
Skip to content

UI: do not show "create github issue" twice if kubeadm init fails #21263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2025
Merged

UI: do not show "create github issue" twice if kubeadm init fails #21263

merged 2 commits into from
Aug 9, 2025

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Aug 7, 2025 •
edited
Loading

closes #21262

before this PR

look in issue for the two box

after this PR (only one exit box)

(forcing it to fail on kubeadm)


$ mk start
😄  minikube v1.36.0 on Darwin 15.6 (arm64)
💡  Unable to run vmnet-helper without a password
    To configure vment-helper to run without a password, please check the documentation:
    https://github.com/nirs/vmnet-helper/#granting-permission-to-run-vmnet-helper
Password: 
✨  Automatically selected the vfkit driver. Other choices: ssh, krunkit (experimental)
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🔥  Creating vfkit VM (CPUs=2, Memory=6144MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.33.2 on Docker 28.3.2 ...
💢  initialization failed, will try again: kubeadm init timed out in 1 minutes

💣  Error starting cluster: kubeadm init timed out in 1 minutes

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯

❌  Exiting due to GUEST_START: failed to start node: kubeadm init timed out in 1 minutes

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2025
@medyagh
Copy link
Member Author

medyagh commented Aug 7, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 7, 2025
@medyagh medyagh changed the title do not show github issue in exist twice if kubeadm UI: do not show "create github issue in exist" twice if kubeadm init fails Aug 7, 2025
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21263 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 50.4s    │ 51.5s                  │
│ enable ingress │ 15.0s    │ 15.2s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 47.1s 50.3s 52.7s 51.0s 50.8s
Times for minikube (PR 21263) start: 50.0s 51.7s 50.9s 53.4s 51.6s

Times for minikube (PR 21263) ingress: 15.0s 15.0s 15.0s 15.9s 15.0s
Times for minikube ingress: 15.0s 14.9s 15.0s 14.9s 15.0s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21263 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.5s    │ 24.0s                  │
│ enable ingress │ 13.1s    │ 13.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 26.0s 22.4s 23.0s 23.0s 22.9s
Times for minikube (PR 21263) start: 24.5s 22.1s 25.3s 22.2s 26.0s

Times for minikube ingress: 13.3s 13.3s 12.3s 12.8s 13.8s
Times for minikube (PR 21263) ingress: 13.8s 12.8s 13.8s 13.8s 13.3s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21263 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.4s    │ 22.5s                  │
│ enable ingress │ 26.1s    │ 29.3s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 38.8s 22.8s 23.3s 22.8s 22.8s
Times for minikube (PR 21263) ingress: 39.3s 22.8s 38.8s 22.8s 22.8s

Times for minikube start: 24.3s 25.6s 25.0s 23.9s 23.2s
Times for minikube (PR 21263) start: 24.0s 23.1s 21.9s 22.4s 21.2s

@medyagh medyagh changed the title UI: do not show "create github issue in exist" twice if kubeadm init fails UI: do not show "create github issue" twice if kubeadm init fails Aug 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ComradeProgrammer,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 6b0b64e into kubernetes:master Aug 9, 2025
27 of 37 checks passed
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Aug 11, 2025
@medyagh @pavansaikrishna78
UI: do not show "create github issue" twice if kubeadm init fails (ku…
582ee8c 
…bernetes#21263)

* do not show github issue in exist twice if kubeadm

* Reset the flag for each test case
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Aug 18, 2025
@medyagh @pavansaikrishna78
UI: do not show "create github issue" twice if kubeadm init fails (ku…
3ec4ccd 
…bernetes#21263)

* do not show github issue in exist twice if kubeadm

* Reset the flag for each test case
pavansaikrishna78 pushed a commit to pavansaikrishna78/minikube that referenced this pull request Sep 9, 2025
@medyagh @pavansaikrishna78
UI: do not show "create github issue" twice if kubeadm init fails (ku…
78475cc 
…bernetes#21263)

* do not show github issue in exist twice if kubeadm

* Reset the flag for each test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer ComradeProgrammer approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exit Advice Prints "Two Boxes" when Kubeadm init fails

4 participants

@medyagh @minikube-pr-bot @k8s-ci-robot @ComradeProgrammer