Add check that there is no PackedDataset while building ConcatDataset #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1796
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bfa7d46 with merge base 57ab583 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Need to fix lint and probably it is fine. @RdoubleA Is the exception text ok? |
|
Actually pretty strange, made pre-commit run for all required files and no changes probably. But let's see CI/CD here |
|
@joecummings Require review |
ebsmothers
reviewed
Oct 10, 2024
torchtune/datasets/_concat.py
Outdated
| for dataset in self._datasets: | ||
| if isinstance(dataset, PackedDataset): | ||
| raise ValueError( | ||
| "ConcatDataset can't proceed instances of PackedDataset." |
There was a problem hiding this comment.
nit
Suggested change
| "ConcatDataset can't proceed instances of PackedDataset." | |
| "ConcatDataset can't process instances of PackedDataset." |
ebsmothers
reviewed
Oct 10, 2024
torchtune/datasets/_concat.py
Outdated
| Raises: | ||
| ValueError: if instanse of `PackedDataset` is in `datasets` | ||
There was a problem hiding this comment.
If I had to guess, this line might be causing the linter whitespace complaint
ebsmothers
reviewed
Oct 10, 2024
|
@ebsmothers Fixed lint. Now should be fine. |
|
Yeah, lint passed. |
|
@ebsmothers can be merged now. |
ebsmothers
approved these changes
Oct 11, 2024
mori360
pushed a commit
to mori360/torchtune
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_testUX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example