Remove unused bsz variable #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: remove unused variables. This could unblock our usecase where the the input is directly the embedding, i.e., b x seq_len x dim. Differential Revision: D64089998 Privacy Context Container: L1268898
zhangtemplar
force-pushed
the
export-D64089998
branch
from
0c3c192 to
fc95880
Compare
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1805
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fc95880 with merge base 5de5001 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64089998 |
RdoubleA
approved these changes
Oct 10, 2024
facebook-github-bot
merged commit c5b7386
into
meta-pytorch:main
18 of 19 checks passed
mori360
pushed a commit
to mori360/torchtune
that referenced
this pull request
Oct 14, 2024
Differential Revision: D64089998 Pull Request resolved: meta-pytorch#1805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: remove unused variables. This could unblock our usecase where the the input is directly the embedding, i.e., b x seq_len x dim.
Differential Revision:
D64089998
Privacy Context Container: L1268898