<memory>: Make algorithms properly destroy objects in constant evaluation
#5449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
May 2, 2025
tests/std/tests/P0784R7_library_support_for_more_constexpr_containers/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0784R7_library_support_for_more_constexpr_containers/test.cpp
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Initial Review
to Work In Progress
in STL Code Reviews
StephanTLavavej
approved these changes
May 3, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 9, 2025
|
ALL WILL BE DESTROYED!!! 🦹 💣 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MSVC STL's destroying algorithms skip ranges whose element types are trivially destructible. This is slightly non-conforming, because further access to the destroyed objects should cause core language UB and in turn cause constant evaluation failure.
This PR makes
std::(ranges::)destroy(_at, _n)always destroy objects during constant evaluation. The behavior difference is currently only observable by Clang due to bugs of MSVC (DevCom-10642767) and EDG (DevCom-10896316).The allocator-aware
_Destroy_rangeis not yet touched, because any attempt to access an element destroyed by that overload will raise library UB first.Related to #5225, although the "vectorized implementation" is no-op in these algorithms.The change aboutif constevalare dropped. See the review comments.