KEMBAR78
Replace `_GET_PROXY_ALLOCATOR` with a function template by frederick-vs-ja · Pull Request #5475 · microsoft/STL · GitHub
Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented May 7, 2025

Also receive its values with auto. Fixes #5448.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner May 7, 2025 15:47
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews May 7, 2025
@frederick-vs-ja frederick-vs-ja force-pushed the modernize-get-proxy-allocator branch from b11194b to ce3390c Compare May 7, 2025 16:06
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label May 7, 2025
@StephanTLavavej StephanTLavavej self-assigned this May 7, 2025
@StephanTLavavej StephanTLavavej removed their assignment May 8, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews May 8, 2025
@StephanTLavavej
Copy link
Member

Thanks for getting rid of this verbose internal macro! 😻

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews May 9, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request May 9, 2025
@StephanTLavavej StephanTLavavej merged commit b8253f7 into microsoft:main May 10, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews May 10, 2025
@StephanTLavavej
Copy link
Member

🐈 🥳 🧹

@frederick-vs-ja frederick-vs-ja deleted the modernize-get-proxy-allocator branch May 10, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

<xmemory>: Should we modernize _GET_PROXY_ALLOCATOR (and its usages)?

2 participants