-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Toolset update: VS 2022 17.14.5 Preview 1, WinSDK 26100 #5580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolset update: VS 2022 17.14.5 Preview 1, WinSDK 26100 #5580
Conversation
…k assertion failed: rhs.is_lvalue() in constexpr.cpp, again".
…led: `p.edges.size() <= 1` comparing converted pointer in constant expression".
…n't accepted by the old lambda processor".
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question, but otherwise LGTM.
@StephanTLavavej - lmk if you need help load balancing the creation of the compiler bugs and other bits you mentioned in the PR you did not have bandwidth for, I may be able to assist (/ I ought to be able, so this can be a forcing function :-P )
📜 Changelog
💡 Notes
source_locationtests for upcoming EDG changes #5551. EDG's output for x86 was slightly different than what we expected, so I'm adjusting the test accordingly. Again, once this updated EDG ships, I'll be able to clean up the test to expect the new output only; right now it's accepting either new or old.basic_format_arg::handle's constructor (unrelated to the old lambda processor). Apparently we're storing a function pointer here for type erasure purposes (I don't really understand this myself, but we can't change the representation of this C++20 class now), but creating that function pointer with a lambda is not necessary. After looking at the lambda, I decided that I didn't like it, so I'm changing to a static member function template (which should be equally good for type erasure).__cdeclto avoid ODR violations, so that's another reason to use a function template.⚙️ Commits
p.edges.size() <= 1comparing converted pointer in constant expression".basic_format_arg::handle's constructor to a function template.