KEMBAR78
Remove support for 32-bit ARM by StephanTLavavej · Pull Request #5594 · microsoft/STL · GitHub
Skip to content

Remove support for 32-bit ARM #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 12, 2025
Merged

Remove support for 32-bit ARM #5594

merged 15 commits into from
Jul 12, 2025

Conversation

@StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jun 15, 2025 •
edited
Loading

🦹‍♂️ DOOM RULES ALL

Ultraboss approved! Mirrored as MSVC-PR-649973.

⚙️ Commits

  • Remove ARM from MSBuild export validation.
  • Remove ARM from Azure Pipelines.
  • Remove ARM from provision-image.ps1.
    • I'll regen the image next month; I'm not concerned about immediately validating this simple change.
  • Remove ARM from the CMake build system.
  • Remove ARM from the test harness.
  • Remove ARM from README.md.
  • Remove defined(_M_ARM) preprocessing, part 1.
  • Remove defined(_M_ARM) preprocessing, part 2.
    • This logic in xatomic.h was slightly more complicated than usual.
  • Remove defined(_M_ARM) preprocessing, part 3.
    • Also remove _ATOMIC_STORE_SEQ_CST_ARM.
  • Remove !defined(_M_ARM) preprocessing.
  • Remove #ifdef _M_ARM preprocessing.
  • Remove #ifndef _M_ARM preprocessing.
  • Rename _Checked_arm_arm64_countl_zero => _Checked_arm64_countl_zero
  • Remove ARM from comments.
  • Remove ARM from UNSUPPORTED comment.

@StephanTLavavej
Remove ARM from MSBuild export validation.
ddfecd2
@StephanTLavavej
Remove ARM from Azure Pipelines.
559118e 
Followup to GH 5580.
@StephanTLavavej
Remove ARM from provision-image.ps1; will regen next month.
57f5f8f
@StephanTLavavej
Remove ARM from the CMake build system.
6e4d840
@StephanTLavavej
Remove ARM from the test harness.
4adc889 
/arch:VFPv4 is ARM-only: https://learn.microsoft.com/en-us/cpp/build/reference/arch-arm?view=msvc-170
@StephanTLavavej
Remove ARM from README.md.
21e9a5e
@StephanTLavavej
Remove defined(_M_ARM) preprocessing, part 1.
63b2318
@StephanTLavavej
Remove defined(_M_ARM) preprocessing, part 2.
19a26b0 
This logic in xatomic.h was slightly more complicated than usual.
@StephanTLavavej
Remove defined(_M_ARM) preprocessing, part 3.
2ecc066 
Also remove `_ATOMIC_STORE_SEQ_CST_ARM`.
@StephanTLavavej
Remove !defined(_M_ARM) preprocessing.
25bc879
@StephanTLavavej
Remove #ifdef _M_ARM preprocessing.
477585c
@StephanTLavavej
Remove #ifndef _M_ARM preprocessing.
a8f856f
@StephanTLavavej
_Checked_arm_arm64_countl_zero => _Checked_arm64_countl_zero
1f6a338
@StephanTLavavej
Remove ARM from comments.
e528795
@StephanTLavavej
Remove ARM from UNSUPPORTED comment.
57a5926
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner June 15, 2025 19:02
@StephanTLavavej StephanTLavavej added enhancement Something can be improved ARM labels Jun 15, 2025
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Jun 15, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews Jun 15, 2025
@StephanTLavavej StephanTLavavej mentioned this pull request Jul 9, 2025
Merged
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in STL Code Reviews Jul 11, 2025
@StephanTLavavej StephanTLavavej merged commit e59dc20 into microsoft:main Jul 12, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Ready To Merge to Done in STL Code Reviews Jul 12, 2025
@StephanTLavavej StephanTLavavej deleted the the-forgotten-arm branch July 12, 2025 00:22
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

Assignees

No one assigned

Labels

enhancement Something can be improved

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StephanTLavavej @davidmrdavid