KEMBAR78
Async Functions for ES6 by rbuckton · Pull Request #3078 · microsoft/TypeScript · GitHub
Skip to content

Conversation

@rbuckton
Copy link
Contributor

@rbuckton rbuckton commented May 8, 2015

Adds support for async functions when targeting ES6 only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'setContextFlags' is not a great name (esp as we have a function call setContextFlag). Maybe 'newContextFlags'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setContextFlags -> contextFlagsToClear
unsetContextFlags -> contextFlagsToSet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

@mhegazy mhegazy mentioned this pull request Jun 19, 2015
rbuckton added a commit that referenced this pull request Jul 1, 2015
@rbuckton rbuckton merged commit b2a871d into master Jul 1, 2015
@rbuckton rbuckton deleted the asyncFunctions branch July 1, 2015 16:51
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants